Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosschain): only use EVM supported chains for gas stability pool and prevent errors to stop iterating other chains #1687

Merged
merged 10 commits into from
Feb 4, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Feb 1, 2024

Description

Closes: #1682

@lumtis lumtis changed the title fix: only use EVM supported chains for gas stability pool and prevent errors to stop iterating other chains fix(crosschain): only use EVM supported chains for gas stability pool and prevent errors to stop iterating other chains Feb 1, 2024
Copy link

github-actions bot commented Feb 2, 2024

!!!WARNING!!!
nosec detected in the following files: x/crosschain/module.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Feb 2, 2024
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis marked this pull request as ready for review February 2, 2024 20:14
@lumtis lumtis merged commit 375cb96 into develop Feb 4, 2024
15 checks passed
@lumtis lumtis deleted the fix/gas-stability-pool-chains branch February 4, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent gas stability pool mechanism to stop if it fails for one chain
3 participants