Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix emission params query and add unit tests #1692

Merged
merged 6 commits into from
Feb 2, 2024
Merged

fix: fix emission params query and add unit tests #1692

merged 6 commits into from
Feb 2, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Feb 2, 2024 •
edited

Description

Returns the param values instead of new params for emissions module

Closes: <#1681>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

ws4charlie
ws4charlie reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Left minor comment

@kingpinXD kingpinXD merged commit 82fb21f into develop Feb 2, 2024
15 checks passed
@kingpinXD kingpinXD deleted the emission-params branch February 2, 2024 23:42
@lumtis lumtis linked an issue Feb 5, 2024 that may be closed by this pull request
Fix GetParams function for emissions #1681
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix GetParams function for emissions
3 participants
@kingpinXD @lumtis @ws4charlie