Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosschain): refund aborted amount #1728

Merged
merged 65 commits into from
Feb 13, 2024
Merged

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Feb 7, 2024

Description

  • Adds refund tx to refund previously aborted transactions
  • Reset ZetaAccounting using a migration script
  • Set IsAbortRefunded flag for all CCTX's which would allow some of them to be refunded if needed
  • Disables auto refunds for cctx's

Closes: #1192

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis changed the title feature: refund aborted amount feat(crosschain): refund aborted amount Feb 7, 2024
proto/crosschain/cross_chain_tx.proto Outdated Show resolved Hide resolved
proto/crosschain/cross_chain_tx.proto Outdated Show resolved Hide resolved
x/crosschain/keeper/cctx_utils_test.go Outdated Show resolved Hide resolved
x/crosschain/keeper/msg_server_vote_inbound_tx.go Outdated Show resolved Hide resolved
x/crosschain/types/message_refund_aborted.go Outdated Show resolved Hide resolved
x/crosschain/keeper/refund.go Outdated Show resolved Hide resolved
x/crosschain/keeper/refund.go Outdated Show resolved Hide resolved
x/crosschain/keeper/refund.go Outdated Show resolved Hide resolved
@lumtis lumtis linked an issue Feb 7, 2024 that may be closed by this pull request
@kingpinXD kingpinXD marked this pull request as draft February 7, 2024 05:56
@kingpinXD kingpinXD marked this pull request as ready for review February 8, 2024 16:27
Copy link

!!!WARNING!!!
nosec detected in the following files: x/emissions/client/tests/suite.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the refund smoke test refund and check aborted cctx instead of comparing amounts

@kingpinXD kingpinXD merged commit 62f9849 into develop Feb 13, 2024
15 checks passed
@kingpinXD kingpinXD deleted the refund-aborted-amount branch February 13, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refund user on ZetaChain when a CCTX is aborted
4 participants