Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add doc for encryption password entry #1731

Merged
merged 13 commits into from
Feb 13, 2024
Merged

docs: add doc for encryption password entry #1731

merged 13 commits into from
Feb 13, 2024

Conversation

kevinssgh
Copy link
Contributor

Description

Added brief description of the new password/encryption feature used by Zetaclient.

Closes: #1701

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis
lumtis reviewed Feb 7, 2024
View reviewed changes
docs/zetaclient/hotkey_tss_passwords.md Outdated Show resolved Hide resolved
docs/zetaclient/hotkey_tss_passwords.md Outdated Show resolved Hide resolved
docs/zetaclient/hotkey_tss_passwords.md Outdated Show resolved Hide resolved
kevinssgh and others added 4 commits February 9, 2024 11:46
@kevinssgh @lumtis
Update docs/zetaclient/hotkey_tss_passwords.md
d71f5ac 
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@kevinssgh @lumtis
Update docs/zetaclient/hotkey_tss_passwords.md
f87df2c 
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@kevinssgh
Merge branch 'develop' into password-doc
7193119
@kevinssgh
update filename
8c55720
@lumtis lumtis changed the title feat: added doc for encryption password entry docs: added doc for encryption password entry Feb 9, 2024
@lumtis lumtis changed the title docs: added doc for encryption password entry docs: add doc for encryption password entry Feb 9, 2024
lumtis
lumtis reviewed Feb 9, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename the file

docs/zetaclient/migration_v12.2->v12.3.md

to keep it more generic in case we have other migration docs in the future

@kevinssgh kevinssgh requested a review from lumtis February 9, 2024 19:19
lumtis
lumtis reviewed Feb 10, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@lumtis lumtis merged commit b4d6080 into develop Feb 13, 2024
14 of 15 checks passed
@lumtis lumtis deleted the password-doc branch February 13, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kingpinXD kingpinXD Awaiting requested review from kingpinXD kingpinXD is a code owner

@fadeev fadeev Awaiting requested review from fadeev

@CharlieMc0 CharlieMc0 Awaiting requested review from CharlieMc0

@CryptoFewka CryptoFewka Awaiting requested review from CryptoFewka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ZetaClient upgrade guide
3 participants
@kevinssgh @lumtis @ws4charlie