Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reset chain nonces msg #1912

Merged
merged 7 commits into from
Mar 20, 2024
Merged

feat: add reset chain nonces msg #1912

merged 7 commits into from
Mar 20, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Mar 19, 2024

Description

Add msg to reset chain nonces

Closes: #1911

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

!!!WARNING!!!
nosec detected in the following files: x/observer/keeper/msg_server_reset_chain_nonces.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Mar 19, 2024
@skosito skosito changed the title Reset chain nonces feat: add reset chain nonces msg Mar 19, 2024
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry under v15.0.0

@skosito skosito marked this pull request as ready for review March 19, 2024 18:21
@skosito skosito requested a review from lumtis March 19, 2024 19:18
@skosito skosito changed the base branch from v14.0.1 to v15.0.0 March 20, 2024 13:09
kingpinXD and others added 2 commits March 20, 2024 14:11
* add v15 upgrade handler

* add changelog entry

* generate files

---------

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@lumtis lumtis merged commit eebeae3 into v15.0.0 Mar 20, 2024
11 checks passed
@lumtis lumtis deleted the add-msg-reset-chain-nonces branch March 20, 2024 16:03
@skosito skosito mentioned this pull request Mar 20, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants