Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20 #2262

Merged
merged 17 commits into from
May 28, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented May 24, 2024

Description

Refactor MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20

MsgPauseZRC20 :  PolicyType_groupEmergency
MsgUnPauseZRC20: PolicyType_groupOperational

Closes: #2244

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

…factor-MsgUpdateZRC20

# Conflicts:
#	docs/cli/zetacored/zetacored_query_crosschain_in-tx-hash-to-cctx-data.md
#	docs/cli/zetacored/zetacored_query_crosschain_list-all-in-tx-trackers.md
#	docs/cli/zetacored/zetacored_query_crosschain_list-in-tx-hash-to-cctx.md
#	docs/cli/zetacored/zetacored_query_crosschain_list-in-tx-tracker.md
#	docs/cli/zetacored/zetacored_query_crosschain_list-out-tx-tracker.md
#	docs/cli/zetacored/zetacored_query_crosschain_show-in-tx-hash-to-cctx.md
#	docs/cli/zetacored/zetacored_query_crosschain_show-out-tx-tracker.md
#	docs/cli/zetacored/zetacored_tx_crosschain_add-to-in-tx-tracker.md
#	docs/cli/zetacored/zetacored_tx_crosschain_add-to-out-tx-tracker.md
#	docs/cli/zetacored/zetacored_tx_crosschain_inbound-voter.md
#	docs/cli/zetacored/zetacored_tx_crosschain_remove-from-out-tx-tracker.md
#	docs/cli/zetacored/zetacored_tx_fungible_pause-zrc20.md
#	docs/cli/zetacored/zetacored_tx_observer_enable-cctx-flags.md
@kingpinXD kingpinXD changed the title refactor: Break MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20 refactor: MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20 May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 68.86%. Comparing base (8144a09) to head (1945878).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2262      +/-   ##
===========================================
+ Coverage    68.82%   68.86%   +0.04%     
===========================================
  Files          261      263       +2     
  Lines        16261    16302      +41     
===========================================
+ Hits         11191    11226      +35     
- Misses        4589     4594       +5     
- Partials       481      482       +1     
Files Coverage Δ
x/fungible/types/message_pause_zrc20.go 100.00% <100.00%> (ø)
x/fungible/types/message_unpause_zrc20.go 100.00% <100.00%> (ø)
x/fungible/keeper/msg_server_pause_zrc20.go 77.77% <77.77%> (ø)
x/fungible/keeper/msg_server_unpause_zrc20.go 77.77% <77.77%> (ø)

@kingpinXD kingpinXD marked this pull request as ready for review May 24, 2024 14:00
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments

proto/zetachain/zetacore/fungible/events.proto Outdated Show resolved Hide resolved
proto/zetachain/zetacore/fungible/events.proto Outdated Show resolved Hide resolved
proto/zetachain/zetacore/fungible/events.proto Outdated Show resolved Hide resolved
x/fungible/keeper/msg_server_pause_zrc20.go Outdated Show resolved Hide resolved
x/fungible/keeper/msg_server_pause_zrc20.go Outdated Show resolved Hide resolved
x/fungible/keeper/msg_server_unpause_zrc20.go Show resolved Hide resolved
x/fungible/keeper/msg_server_pause_zrc20.go Outdated Show resolved Hide resolved
x/fungible/keeper/msg_server_unpause_zrc20.go Outdated Show resolved Hide resolved
@kingpinXD kingpinXD requested a review from lumtis May 27, 2024 16:04
@kingpinXD kingpinXD merged commit b73fbcf into develop May 28, 2024
21 checks passed
@kingpinXD kingpinXD deleted the refactor-MsgUpdateZRC20 branch May 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate MsgUpdateZRC20 into MsgPauseZRC20 and MsgUnPauseZRC20
3 participants