Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete static zetacore/zetaclient config/keys #2351

Merged
merged 1 commit into from
Jun 19, 2024
Merged

chore: delete static zetacore/zetaclient config/keys #2351

merged 1 commit into from
Jun 19, 2024

Conversation

gartnera
Copy link
Member

Description

  • zetacored configs were not used at all
  • zetaclientd keys being deleted means that tss keys will need to be generated every run. I think the zetaclientd keygen is important logic to exercise every e2e run. It added ~10 seconds to my local e2e run.

Relates to #2238

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@gartnera gartnera added the no-changelog Skip changelog CI check label Jun 19, 2024
lumtis
lumtis approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lumtis lumtis merged commit d4a9f7d into develop Jun 19, 2024
19 of 20 checks passed
@lumtis lumtis deleted the refactor-e2e-secrets-2 branch June 19, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

@skosito skosito Awaiting requested review from skosito skosito is a code owner

@swift1337 swift1337 Awaiting requested review from swift1337 swift1337 is a code owner

Assignees
No one assigned
Labels
no-changelog Skip changelog CI check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gartnera @lumtis @kingpinXD