Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove handler.go #497

Merged
merged 2 commits into from Apr 10, 2023
Merged

refactor: remove handler.go #497

merged 2 commits into from Apr 10, 2023

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Apr 6, 2023

Description

Starting from Cosmos SDK v0.46 handler.go files are no longer required. They are actually not being used anywhere in the code, so it's safe to remove them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@brewmaster012
Copy link
Collaborator

@fadeev looks good! Did not know that handler has been deprecated.

@fadeev
Copy link
Member Author

fadeev commented Apr 7, 2023

@brewmaster012 yes, they have been deprecated and removed from Cosmos SDK standard modules.

@brewmaster012
Copy link
Collaborator

@fadeev would you like to merge this soon?

@fadeev
Copy link
Member Author

fadeev commented Apr 10, 2023

Sure, as soon as it gets reviewed.

Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fadeev fadeev merged commit 0ca7093 into develop Apr 10, 2023
9 checks passed
@fadeev fadeev deleted the refactor/handler branch April 10, 2023 16:05
CharlieMc0 pushed a commit that referenced this pull request Jun 27, 2023
CharlieMc0 pushed a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants