feat(telemetry): add zetaclientd :8123/version endpoint #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it less confusing. btcd library expects IP:PORT or HOSTNAME:PORT as the RPCHost format.
as the build rule in Makefile uses .git/ to find tags and generate version string.
CharlieMc0
approved these changes
May 23, 2023
CharlieMc0
pushed a commit
that referenced
this pull request
Jun 27, 2023
* refactor: rename bitcoin RPCEndpoint to RPCHost to make it less confusing. btcd library expects IP:PORT or HOSTNAME:PORT as the RPCHost format. * chore: remove .git from dockerignore file as the build rule in Makefile uses .git/ to find tags and generate version string. * zetaclient: add :8123/version endpoint --------- Co-authored-by: brewmaster012 <>
CharlieMc0
pushed a commit
that referenced
this pull request
Jun 27, 2023
* refactor: rename bitcoin RPCEndpoint to RPCHost to make it less confusing. btcd library expects IP:PORT or HOSTNAME:PORT as the RPCHost format. * chore: remove .git from dockerignore file as the build rule in Makefile uses .git/ to find tags and generate version string. * zetaclient: add :8123/version endpoint --------- Co-authored-by: brewmaster012 <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint returns the version string specified at build time, the same output as the
zetaclientd versioncommand (#541).Example
closes #615