-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add svg support and impove the speed #118
Conversation
@jiayp Can you tack on some specs the methods you added? Also, I'm curious about the speed improvements. Do you have any benchmarks? I'd be cool to see where we should focus performance efforts. |
I'm a experienced ruby coder, but not for javscript and opal. In my project I found this result in chrome's profile before this changes
The first one is couse by react's prop type check,and remove for production mode in react 0.14. I rewrite the code using native js and the the second to fourth line disappeared from chrome's profile. If need I can test again, and give the exactly result. |
The good news is, it is easy to learn because opal-rspec is pretty much exactly like ruby rspec. There's not really any JS required. You can write the tests in Ruby. We've already got a test suite that you can work with in the First, make sure you can run the existing tests:
One thing to pay attention to is which platform you are targeting for the test to run. If you are testing Ruby meant to be compiled by Opal into JS (which in this case you are), make sure your specs are inside an If you'd like to take a stab at it, I'll help you if you hit any road blocks. |
OK I'll do it for svg. |
You don't need to test the performance; just test that the added methods have the correct behavior. |
Add SVG attributes
I got this error, how to fix it.
|
Ah, you need to install PhantomJS. If you are on a mac you can run |
@ajjahn thanks, please check my pull request. |
I got this
So I run
|
@ajjahn My commited code is tested by github ci.You can check it. |
@jiayp Thanks for seeing this through! If you're interested in getting the tests running locally, it looks like the method for installing PhantomJS on El Capitan is:
It's discussed in Homebrew/legacy-homebrew#44535. |
This issue was moved to ruby-hyperloop/hyper-react#118 |
No description provided.