Fix getRelatedParts() in multipart_related #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey - what exactly does this fix? And could you add a test case please? |
|
I think getRelatedParts() should return all parts when mainPart not null and without first part if mainPart is null. Is it correct? Or I should doing array_merge($multiplart->getMainPart(), $multipart->getRelatedParts()) to get all parts? |
|
Are you proposing to change existing behaviour? Did you run the test cases after your change? |
|
I'm thought this is bug but apparently this is feature. Then I propose to add new method for getting all parts. |
|
Closing this as it's not a bug. Please make a new PR with a new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.