Prevent returning undefined variable #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $data variable might not be set, this commit makes sure it is only returned when set.
|
I'll have a better look soon, but how did you managed to find this? Is there a chance of a test case? ;-) |
|
Hi Derick, unfortunately not, but looking at the code it's clear that the variable actually can be undefined, but is still returned :) I did however get the error in my log a couple of times: I think it might have something to do with an (unexpected) connection error, but i'd have to dive into the imap server's logs. |
derickr
added a commit
that referenced
this pull request
Jan 11, 2020
|
Thanks! I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The
$datavariable might be undefined outside if thisif, only return it when it has been defined.