Draft: endpoint button #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGRCL
reviewed
May 14, 2024
Comment on lines
+51
to
+64
| <ClosableModal | ||
| modalHeading="The following error(s) occurred:" | ||
| passiveModal={true} | ||
| open={isOpen} | ||
| onRequestClose={() => setIsOpen(false)} | ||
| > | ||
| <div className="flex flex-col gap-4 p-3"> | ||
| {validationErrorMsg.map((error, i) => { | ||
| return ( | ||
| <p key={"error-msg-"+i}>{error}</p> | ||
| ) | ||
| })} | ||
| </div> | ||
| </ClosableModal> |
There was a problem hiding this comment.
Are going to keep this modal? If yes I think you can replace this with the plain Modal component from carbon
| }) | ||
|
|
||
| const endpoint = async (pipeline) => { | ||
| const res = await mutation.mutateAsync(pipeline.id) |
There was a problem hiding this comment.
I think this function call can throw an error, so you might want to wrap it in a try-catch
|
|
||
| return ( | ||
| <> | ||
| <Button style={styles} size="sm" onClick={() => { endpoint(pipeline) }}> |
There was a problem hiding this comment.
you could use tailwinds m-1 or m-[5px] class instead here.
| @@ -153,6 +154,9 @@ export default function Navbar({ children }) { | |||
| <RunPipelineButton modalPopper={modalPopper} action="Run"> | |||
| <Play size={20} style={svgOverride} /> | |||
| </RunPipelineButton> | |||
| <GetEndpointButton modalPopper={modalPopper} action="Something"> | |||
There was a problem hiding this comment.
Maybe the action should be more specific, something like action="Deployment"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a button to return the endpoint associated to a deployed pipeline.