Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new map to show off water/naval units #96

Closed
tbeddy opened this issue Aug 1, 2017 · 8 comments · Fixed by #105
Closed

Add new map to show off water/naval units #96

tbeddy opened this issue Aug 1, 2017 · 8 comments · Fixed by #105

Comments

@tbeddy
Copy link
Contributor

tbeddy commented Aug 1, 2017

Zetawar currently has two built-in maps, neither of which gives very much room (if any) for ships. A new default map should include a significant number of deep-water and shallow-water terrains, though not enough for naval combat to dominate gameplay.

@tbeddy
Copy link
Contributor Author

tbeddy commented Oct 10, 2017

@djwhitt Would using one of the default maps from Elite Command be okay for this? We'd obviously add credit in the code and probably in the UI too. I was thinking of writing a cljs script for lumo to convert EC maps for ZW.

@djwhitt
Copy link
Contributor

djwhitt commented Oct 20, 2017

Sure, pulling in an Elite Command map would be great. We should probably add something to the map data structure to support attribution. A Lumo converter sounds cool too.

@tbeddy
Copy link
Contributor Author

tbeddy commented Oct 22, 2017

EC includes a description for each of its maps. For example, "Little Island" has "A tiny war on a tiny island." Should I include this info? We could change :description to :title in our map data structure to accommodate this.

@djwhitt
Copy link
Contributor

djwhitt commented Oct 24, 2017

Yep, that sounds reasonable. Though, I'd like to keep the new more verbose description optional.

@tbeddy
Copy link
Contributor Author

tbeddy commented Oct 24, 2017

Do you mean not load it into the DB at all, or just use something else (like the title or a blank string) if a description isn't available?

@djwhitt
Copy link
Contributor

djwhitt commented Oct 27, 2017

Not loading it into the DB at all if it's missing is probably best. The UI should also gracefully handle a lack of description.

@tbeddy
Copy link
Contributor Author

tbeddy commented Oct 31, 2017

I'm thinking of using something like :notes for the longer description instead. I don't like how :title/:description breaks with every other use of :description.

@djwhitt
Copy link
Contributor

djwhitt commented Nov 3, 2017

Agreed, I like that better. I was a little uncomfortable with :title / :description too, but didn't have a better idea. I'm glad you thought of one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants