Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant campId query parameter automatically added in calendar URLs #1416

Closed
richardolsson opened this issue Jun 3, 2023 · 0 comments · Fixed by #1887
Closed

Redundant campId query parameter automatically added in calendar URLs #1416

richardolsson opened this issue Jun 3, 2023 · 0 comments · Fixed by #1887
Assignees
Labels
🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐟 Small Should be a quick-ish fix.

Comments

@richardolsson
Copy link
Member

Description

When navigating the global calendar (the one that includes all events, regardless of project/campaign), there is a redundant campId query parameter added to the URL.

Steps to reproduce

  1. Go to http://localhost:3000/organize/1/projects/calendar

Expected Behaviour

URL should be rewritten to include focusDate and timeScale.

Actual Behaviour

URL is rewritten to include campId, focusDate and timeScale.

Screenshots

image

Possible solutions

I believe this is because of the logic that syncs the calendar's internal state with the URL, introduced (or rather, modified) by #1384. It adds the campId property which is necessary for project-specific calendars, e.g. http://localhost:3000/organize/1/projects/1/calendar, but there probably needs to be some condition to only add it to the object when there is a project/campaign.

@richardolsson richardolsson added 🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐟 Small Should be a quick-ish fix. labels Jun 3, 2023
@ziggabyte ziggabyte self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐟 Small Should be a quick-ish fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants