-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react & react-dom to 18.3.0 and fix playwright flakiness #1807
Merged
richardolsson
merged 22 commits into
zetkin:main
from
henrycatalinismith:undocumented/react-18.3.0-plus-playwright-fixes
Mar 17, 2024
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0b6ce07
Install canary versions of react and react-dom 18.3.0
henrycatalinismith 3010797
Try to fix campaign list test
henrycatalinismith b6eb3a5
Wait for render before counting elements
henrycatalinismith 6d6a005
Wait for render before counting elements
henrycatalinismith 2873b26
Wait for render before counting elements
henrycatalinismith 7ef42c4
Wait for visible state instead of asserting it
henrycatalinismith ebd0f49
Wait for render before counting elements
henrycatalinismith 00c834a
Wait for render before counting elements
henrycatalinismith d3c7007
Wait for status to visibly change before counting API calls
henrycatalinismith d0a5b9a
Wait for search button to render before invoking keyboard shortcut
henrycatalinismith c7e7fe8
Wait for render before counting elements
henrycatalinismith 964ab3a
Wait for tag to appear on page before counting API calls
henrycatalinismith 4e2d8db
Wait for delete button to appear before clicking it
henrycatalinismith 8eab52d
Wait for date picker to appear before clicking it
henrycatalinismith be0defc
Wait for tag to disappear from page before counting API calls
henrycatalinismith a30f8c1
Wait for buttons to appear before clicking them
henrycatalinismith d156b92
Add missing /orgs/1/people/views mock
henrycatalinismith 8dc2578
Wait for June 24 to appear before clicking it
henrycatalinismith aba1c20
Don't use Promise.all unnecessarily
henrycatalinismith 1b40c75
Load TypeKit using CSS link embed code instead
henrycatalinismith b5ab00e
Remove superstitious Promise.all and brittle nth() usage
henrycatalinismith d5d7c50
Fix mistakes in previous commit
henrycatalinismith File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (using locators instead of
$$eval
) is a clear improvement IMO.