fix(opts): filter now optional and matches whole url #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* HASTILY_STREAMABLE_PATH_REGEXP now matches the whole URL (making it compatible with Express middleware paths) * hasSupportedExtension now tests against the Express `req.originalUrl` instead of `req.path`, so it can be used in early Express middlewares before the `req.path` is populated
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 251 251
Branches 49 49
=========================================
Hits 251 251 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
HASTILY_STREAMABLE_PATH_REGEXP now matches the whole URL (making it compatible
with Express middleware paths)
hasSupportedExtension now tests against the Express
req.originalUrlinsteadof
req.path, so it can be used in early Express middlewares before thereq.pathis populatedReplaces and closes #22.