-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed to change language for appcompat:1.2.0-rc02 #15
Comments
Check https://github.com/akexorcist/Localization/tree/1.2.5 - it works ok |
Thanks for your report. I tried with Could you tell me what version of the library you're using? Please try to use version |
I check it on 1.0.4 on Android 9 (API 28) and the bug reproduces only when app starts. |
What exactly not working on app start? Did you apply all of the necessary steps? It should be working fine. |
Here is a test: https://github.com/altush1983/locale-helper-android-test
It works ok if replace Test it on emulator:
|
Yes, you're right. 1.2.0-rc02 causing a lot of problems. Also I noticed that when you don't use |
Looks like https://github.com/akexorcist/Localization/tree/1.2.5 works ok: al-tush/locale-helper-android-test@4561e7f (I just re-tested it) |
I pulled the latest changes in your test repo and it doesn't work after the first run. |
I have same problem? please help |
Let's focus on stable releases |
Same problem applies to appcompat stable release as well. When the app is first created, language setting is retrieved but the views can't benefit from it. Resuming after home button click doesn't affect the situation, but restarting activity after exiting the app with the back key solves it. Triggering a rebirth also does the job. |
@thereisonlywe I don't observe it on the example app that is shared on this repo. Which stable version do you use? And can you test with the example app? |
appcompat 1.2.0 released. but it's not working properly with the helper. |
Working on a fix which would fix any issues for |
Published a version
|
still has issues. application context didn't get changed after switching locale. i also have issues switching between zh_CN and zh_TW. my app has en, zh_cn, zh_tw, only en and zh_cn work after upgrading. |
@beeshop-daniel can you share a sample app so that I can work on it to solve the problem? |
i will try to create a quick sample app for u. |
Works perfectly on Android 11 Beta with |
Hey mates. I also have this problem and I also found this sample to work just fine - https://josipsalkovic.com/2020/05/01/changing-locale-uimode-runtime-android/ What I think is the key here is these lines of code: this method is simplified but works perfectly
|
@shiSHARK There are a lot of combinations going on like Android version, appcompat version etc. Have you really tested with API level 16 to 29 and with different app compat versions? Please also check it out |
I have tested on 24 to 29 - these are the version we use and also only on androidx.appcompat:appcompat:1.2.0 |
locale-helper-android: 1.1.0-beta1 Android 11 - works. |
Published a version
If anyone can test the beta version, I will publish the Note: The versions that I tested with are the following: Thanks. |
Released |
Failed to change language for version 1.2.0-rc02 (and rc01) of androidx.appcompat:appcompat.
It is important because androidx.appcompat:appcompat:1.1.0 have some major issues (like highcharts/highcharts-android#115 ) with old Android versions.
The text was updated successfully, but these errors were encountered: