New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
definitions for asus Zenith II Extreme #26
Conversation
Thank you for the contribution! From a quick look |
Here is the output when using
With this family, the Just for context, my interest here was actually to monitor the VRM temperature and fan speed, as the VRM heatsink fan is going a bit bonkers. For the above, I also reconnected the VRM HS Fan, so it reports the speed correctly. The motherboard has two temperature sensors ( The BIOS reports these sensors:
The checked ones are the ones reporting a value on the BIOS. I can check some others by moving a fan around, but I don't have a Node power supply or a complex enough water pump (mine is just plugged into CPU_FAN header). I don't know if there are any more values we can get, like If there is any more I can try out or info I can find to get this working and merged, I'd be happy to help. |
Agree, these numbers look OK to me.
Just guessing and checking various EC registers. You can use the ec_sys kernel module to dump EC registers from the first bank (bank index 0) and look for 216 (0xd8) when T_sensor2 is disconnected, as that is the blank value for temperature sensors (-40 deg Celsius). For the second bank you have to use more complicated approach. You can play with this module and add a bunch of fake sensors to cover several registers at once and check them. In this declaration: |
Dsdt table in this comment from the related issue #16 |
@nabajour, could you also test, please, does the following sensor |
Thank you! |
I did not find it in the DSDT code. |
I appended those two sensors:
And got this output:
|
With
With the sensors disconnected:
We have |
Thank you, it is probably "water block out" then at 0x03. There is no second disappearing "d8" here. Thus it is probably in the next bank. |
I think the T_Sensor2 should be not far from the beginning of the bank, because ASUS seems to be filling the second bank consequently. So I would just create ten fake temp sensors starting from EC_SENSOR("Dummy_T0", hwmon_temp, 1, 0x01, 0x04). Reading arbitrary EC registers should do no harm to PC. |
Hi, I create these sensors:
with This is the
Il looks like |
That's great! Thank you for the experiment! Not only you found out the address for T_Sensor2, but looks like discovered another two temperature sensors at 0x0b & 0x0c! |
Does anything else hold you from wrapping this up? |
Isn't there also one at |
Mostly me being caught up in other stuff. I also read some introduction doc for ACPI and DSDT, but don't understand a lot. I was wondering if there was info in there to identify other sensors. And I'm not sure how to know what those extra sensors are for, so I'll just name them "extra" for now. |
Of course, that's similar to 0x0b & 0x0c. |
Output with latest pushed changes:
|
The previous generation of ASUS boards had full hardware monitoring solution implemented in the DSDT table, now they just provide WMI functions to read Super I/O and EC ports for their Windows software. However, this information is surely present somewhere in .CAP files, which can be decompiled. I'm talking about the hardware monitor in BIOS, of course. But seems like to locate that information one needs hacking skills and time I'm lacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a few minor changes.
…block. Sort sensors by register address. Fix whitespace. Add some comments. Fix whitespace.
Thanks for the pointers! One more rabbit hole to go down when I find some time. Some guys did decompilation of the BIOS at overclockers.net, maybe there is more info over there.
I totally understand. Thanks for doing this work! |
That would bring this driver to a whole new level, because one can download BIOS files for any model.
Thank you for the valuable contribution! |
Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are accessible at [1,2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Nabajour <nab@halo.lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org>
BugLink: https://bugs.launchpad.net/bugs/1994068 [ Upstream commit 9992b19 ] Add definitions for ROG ZENITH II EXTREME and some unknown yet temperature sensors in the second EC bank. Details are available at [1, 2]. [1] zeule/asus-ec-sensors#26 [2] zeule/asus-ec-sensors#16 Signed-off-by: Urs Schroffenegger <nabajour@lampshade.ch> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220710202639.1812058-2-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Stable-dep-of: 88700d1 ("hwmon: (asus-ec-sensors) autoload module via DMI data") Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
I adapted my changes for the Zenith II Extreme I made a while ago to your new code architecture.
Here is the output of
sensors
Tell me if this looks ok to you.
Thanks