Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings from C code #11

Closed
fredrikz opened this issue Oct 19, 2018 · 1 comment
Closed

Warnings from C code #11

fredrikz opened this issue Oct 19, 2018 · 1 comment

Comments

@fredrikz
Copy link

It would be nice if volk could fix some warnings emitted from the volk.h/volk.c when enabling really high warning levels, both on Windows and Linux. The offending code is declarations and definitions which uses the form:

VkResult foo();
VkResult foo() {
...
}

instead of

VkResult foo(void);
VkResult foo(void) {
...
}

On VS2017 the warning emitted is C4255 (https://msdn.microsoft.com/en-us/library/0k9z2ey4.aspx) and on Linux -Wstrict-prototypes (which complains about the missing void) and -Wmissing-prototypes (which follows since the prototypes aren't defined). All in all, not a big issue, but also a simple fix?

@zeux zeux closed this as completed in adb25b8 Oct 19, 2018
@zeux
Copy link
Owner

zeux commented Oct 19, 2018

Thanks! I wasn't aware of this distinction previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants