-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Add class ECCameraPreviewView #71
base: master
Are you sure you want to change the base?
Feature - Add class ECCameraPreviewView #71
Conversation
@allenlinli sounds promising! give me a few days to review this, thank you for your support. |
Hi @allenlinli, just a few comments before actually review it. Please keep the header paragraph, license and copyright as any other files in the project.
Well, if I understand your question the reason is that the class didn't existed before. |
Thanks zevarito :) , I will add the header paragraph. |
Sorry about not keep license and copyright correctly, I will learn about copyright later. |
Hi zevarito,
I add a new class
ECCameraPreviewView
to provide a mirror stream view.It's based on
RTCCameraPreviewView
, which is used in demo code "APP RTC Mobile iOS"Please feel free to suggest it on code review, or open a pull request on this pull request to modify it :)
Notes:
ECPlayerView
by making RTCEAGLVideoView or its layer mirrored. I may give another PR for its implementation later.RTCEAGLVideoViewDelegate
now since I don't know how to connect it so far.RTCCameraPreviewView
, which is based onAVCaptureVideoPreviewLayer
(https://goo.gl/Vw355f). I wonder why do we need a capture session especially, and why do WebRTC provideRTCCameraPreviewView
, not a mirror property onRTCEAGLVideoView
(https://goo.gl/84u6To)? I ask for a feature request on WebRTC already (https://bugs.chromium.org/p/webrtc/issues/detail?id=9164), but I think our PR goes faster.Cheers.