Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libayatana-appindicator library to telega-server #413

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

jumper047
Copy link
Contributor

Ubuntu 22 drops support of the libappindicator library in prior to libayatana-appindicator. It still has libappindicator in it's repo, but ubuntu-desktop package depends on ayatana version, so user can't just install libappindicator. You can check some background here - AyatanaIndicators/libayatana-appindicator#30 (comment).

Luckily, libayatana-appindicator interface is identical to libappindicator, so I added some additional ifs to use any of those libraries with telega-appindicator.

@zevlg
Copy link
Owner

zevlg commented Apr 19, 2023

Thanks, but could you please revert changes to doc/ folder. In some future we will get documentation things fully automated. Also, does etc/Dockerfile also requires that new appindicator library?

@jumper047 jumper047 force-pushed the feat-libayatana-appindicator branch from d5306f4 to 05fbf10 Compare April 19, 2023 23:40
@jumper047
Copy link
Contributor Author

revert changes to doc/

done

does etc/Dockerfile also requires that new appindicator library?

I'll try to test it - if I understand it right, telega-server manipulates tray icon via appindicator library inside container. If this statement is correct , then, maybe, it's worth to update it because new library is maintained by community and old one - not.

@zevlg zevlg merged commit 879a8c7 into zevlg:master Apr 20, 2023
@zevlg
Copy link
Owner

zevlg commented Apr 20, 2023

Merged in, thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants