-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for snap packaging (via snapcraft) #29
Conversation
Try to get the current binary path from argv[0] in order to find the wav files when not runing from sources.
Still in devmode...
Set better openal settings on startup in the snap environment
Huh? Packaging stuff does not belong upstream. You don't include debian/, do you? Besides, Ubuntu has dpkg as well. -nik |
Hi Marco, Thanks for packaging up, but I'm not sure though if I want to collect I know that for debian it's not common to add the packaging stuff to I'd be happy to add any references to packages to the documentation, if
:wq |
Ah, oh, that was a pull request, not a commit mail…
|
Snaps are meant to be managed directly by upstream that can easily push them in the Ubuntu store when they want to release without having to worry about someone else to manage this part. Also snaps are supported by multiple other distros, other than Ubuntu. And this is different from dpkg as it's confined and secured. Also it's now and will be the preferred way to distribute software for Ubuntu.
Yeah, the same can be done easily with snaps, as the source of a snapcraft.yaml can also be a git repository like this, but as said above snaps are meant to be managed directly by upstream projects, as you can decide when to release to different channels without having the distro to care about this, and without the risk of breaking anything.
Yeah, I've submitted the package already to the ubuntu snap store, however it's something you could also manage directly without having others to handle it. In any case, if you're not interested in this you can link the snap (once available in the store) and I'll do a different project for managing only the snapcraft.yaml. While I could propose a branch containing only the this commit. Let me know... |
Hey, any update on this? If you don't want to keep this upstream, just let me know so that I can just propose the unrelated bits and keep the snapcraft.yaml stuff somewhere else. |
Hi Marco, I'll look into it this weekend, thanks |
Marco, Sorry, but I'm not too happy adding a lot of new files just for the sake of supporting snap packaging. I can merge your changes in main.c though to try to find the samples relative to the binary path, would that help you out? |
No problem... I'll move the snap stuff in a different repo (if you want it under your umbrella, just let me know), while I'll propose only that change. FYI the snap package is already available in the store though: https://uappexplorer.com/app/bucklespring.3v1n0 Cheers |
@zevv, any interest in revisiting this? The snap has some popularity, maybe you might want to handle that alone? Let me know. |
This adds the ability of packaging this app using snap packages (see http://snapcraft.io/) that are used by Ubuntu.
This allows also to set openAL settings without breaking the default user settings.
Improved also the way this app looks for .wav files, by looking in the binary path (not fully reliable in all the OSes, but it's an improvement that allows to avoid passing the wav path from the snap wrapper script).