async minor

[ringabout]

No description provided.

[ringabout]

Is this expected behaviour?

[ThomasTJdev]

Is this expected behaviour?

Please elaborate, what you mean? Yes, it looks as correct mqtt packages received listening on global topic #.

[ringabout]

I just run test in when isMainModule

when isMainModule:
  proc flop() {.async.} =
    let ctx = newMqttCtx("hallo")

    #ctx.set_host("test.mosquitto.org", 1883)

    ctx.set_host("test.mosquitto.org", 8883, true)

    await ctx.start()
    proc on_data(topic: string, message: string) =
      echo "got ", topic, ": ", message

    await ctx.subscribe("#", 2, on_data)
    await ctx.publish("test1", "hallo", 2)
    await sleepAsync 1000
    await ctx.close()

  waitFor flop()

[ThomasTJdev]

The listening on # seems fine, but your publish on test1 has not gone through. I have actually never testet against test.mosquitto.org - only on my own servers.

await ctx.publish("test1", "hallo", 2, true) # Insert true condition to wait for package confirmation (4-way handshake).
await sleepAsync 5000 # Or increase time.

[ThomasTJdev]

I made a mistake. We need the asyncCheck.

[ringabout]

@zevv sorry, I made a mistake. We should revert "asyncCheck ctx.sendDisconnect()" to "discard await ctx.sendDisconnect()"
As for other changes,the use of {.async.} is a heap allocation,so sometimes {.async.} is expensive.Maybe we can avoid it.
https://github.com/dom96/jester/pull/236/files

[zevv]

Quoting flywind (2020-03-16 00:48:37)

@zevv sorry, I made a mistake. We should revert "asyncCheck ctx.sendDisconnect()" to "discard await ctx.sendDisconnect()"

Ok!

As for other changes,the use of {.async.} is a heap allocation,so sometimes {.async.} is expensive.Maybe we can avoid it.

Hm, that sounds a bit like premature optimization: there is tons of heap allocations going on with all the packet building and seq handling, so not sure if this really pays of at this time..

…

-- :wq ^X^Cy^K^X^C^C^C^C