This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
Return workers response asap #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2019
|
I've just tested this and I am still having the same issue as before: |
|
@lb20 Thanks for testing. I've updated code, it should work now. I don't have how to test it now, so it was done blindly. |
|
Unfortunately, I'm still having the same issues: I definitely have some of the sensors in range, checked: |
|
Hmm looks like that miflora with D0 is out of range, try to reorder config, and put that device on the bottom. Thay way you should get update from devices that are in the range most of the time. Looks like this worker should have some per device timeout, except of global timeout per worker. But reordering device in config could help for now, with change in this PR. |
|
Added timeout per device, maybe now it will work better in this case. |
|
How can we get this updates? Via git pull? |
Yes do git pull and then |
|
I get error: |
|
Try |
|
|
Looks like its not git repo ? Maybe try downloading it again ( git clone ... ), but remember to preserve config https://github.com/zewelor/bt-mqtt-gateway#virtualenv |
|
Thank you, have it now!? |
|
Yes now it looks ok, now run gateway as always, and you should be on this test code version. |
|
Thanks, but can not start now with branch return_workers_response_asap: If I git checkout -f master, then works again |
|
Thanks so much @zewelor it's working great now! |
I didn't need to re-order the devices in my config, the timeout works perfectly per device! |
|
@joselito11 Ive made string formatting with python 3.6 syntax, I've fixed it now to make it work on 3.5. Update code and try again @lb20 I've made some fixes in handling exceptions, everything should still work, can you retest it to be sure ? |
Thank you! Working! |
All working! |
|
Great, thanks for testing, lets get this merged. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When one device, in worker, timeouts, none of the messages from devices that responded, are being sent via mqtt. It should be fixed now.
Fixes #65, #95
Type of change
Please delete options that are not relevant.