Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [COR-916] Use proxy config to make outbound connections through internet #517

Merged
merged 10 commits into from
May 23, 2024

Conversation

keshavbhatt
Copy link
Member

@keshavbhatt keshavbhatt commented May 17, 2024

What's changed:

  • zimbraHttpProxyURL global, server attribute is single cardinal now
  • use proxy config in PostHogTracking
  • use proxy config in CallToHome
  • refactor/cleanup of HttpProxyUtil
  • refactor/cleanup of CallToHome
  • remove proxy config from PreviewServlet since it is not required (internal connection)
  • move ProxyServlet from zimlet package + minor cleanup

Related PRs:

@keshavbhatt keshavbhatt requested a review from a team as a code owner May 17, 2024 10:01
@keshavbhatt keshavbhatt requested review from sonersivri, AlessioCoser and frisonisland and removed request for a team May 17, 2024 10:01
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (27.70% Estimated after merge)
  • Duplications No duplication information (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@keshavbhatt keshavbhatt changed the title feat: [COR-916] Make zimbraHttpProxyURL single cardinal feat: [COR-916] Use proxy config to make outbound connections through internet May 21, 2024

This comment was marked as outdated.

This comment was marked as outdated.

1 similar comment

This comment was marked as outdated.

Copy link

Failed

  • 25.00% Coverage on New Code (is less than 80.00%)
  • 6 New Issues (is greater than 0)

Analysis Details

6 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 6 Code Smells

Coverage and Duplications

  • Coverage 25.00% Coverage (27.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

Copy link

Failed

  • 25.00% Coverage on New Code (is less than 80.00%)
  • 6 New Issues (is greater than 0)

Analysis Details

6 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 6 Code Smells

Coverage and Duplications

  • Coverage 25.00% Coverage (27.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@keshavbhatt keshavbhatt merged commit fa4be90 into devel May 23, 2024
2 of 3 checks passed
@keshavbhatt keshavbhatt deleted the COR-916 branch May 23, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants