PR review comments #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicojs
commented
May 3, 2021
|
|
||
| export type ScriptFormat = AstFormat.JS | AstFormat.TS | AstFormat.Tsx; |
There was a problem hiding this comment.
Added this helper type, so we won't have to list all 3 of them all the time.
nicojs
commented
May 3, 2021
| @@ -19,6 +19,9 @@ describe(`${disableTypeChecks.name} integration`, () => { | |||
| it('should be able disable type checks of a vue file', async () => { | |||
There was a problem hiding this comment.
Rest is the PR is adding unit and integration tests
nicojs
commented
May 3, 2021
| /** | ||
| * Represents a TS AST | ||
| */ | ||
| export interface TsxAst extends BaseAst { |
There was a problem hiding this comment.
I've created tsx as its own Ast, that way its a bit more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.