take timezone into account #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolic
requested changes
Feb 25, 2017
src/Model/AbstractToken.php
Outdated
| @@ -158,15 +159,15 @@ public function getExpiresAt() | |||
| */ | |||
| public function getExpiresIn(): int | |||
| { | |||
| return $this->expiresAt->getTimestamp() - (new DateTime('now'))->getTimestamp(); | |||
| return $this->expiresAt->getTimestamp() - (new DateTime('now', new DateTimeZone(date_default_timezone_get())))->getTimestamp(); | |||
There was a problem hiding this comment.
I would go with UTC because of changing time to winter and summertime.
prolic
approved these changes
Feb 25, 2017
|
Failed on php7 |
|
that failure is due to new Date != new Date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.