Remove useless setters from events

zf-fr · May 2, 2014 · 553dc70 · 553dc70
1 parent 2502978
commit 553dc70
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 69 deletions.
diff --git a/src/ZfrRest/Mvc/Controller/Event/HydrationEvent.php b/src/ZfrRest/Mvc/Controller/Event/HydrationEvent.php
@@ -81,14 +81,6 @@ public function getAutoHydrate()
         return $this->autoHydrate;
     }
 
-    /**
-     * @param ResourceInterface $resource
-     */
-    public function setResource(ResourceInterface $resource)
-    {
-        $this->resource = $resource;
-    }
-
     /**
      * @return ResourceInterface
      */
@@ -97,14 +89,6 @@ public function getResource()
         return $this->resource;
     }
 
-    /**
-     * @param AbstractPluginManager $hydratorManager
-     */
-    public function setHydratorManager(AbstractPluginManager $hydratorManager)
-    {
-        $this->hydratorManager = $hydratorManager;
-    }
-
     /**
      * @return AbstractPluginManager
      */

diff --git a/src/ZfrRest/Mvc/Controller/Event/ValidationEvent.php b/src/ZfrRest/Mvc/Controller/Event/ValidationEvent.php
@@ -82,14 +82,6 @@ public function getAutoValidate()
         return $this->autoValidate;
     }
 
-    /**
-     * @param ResourceInterface $resource
-     */
-    public function setResource(ResourceInterface $resource)
-    {
-        $this->resource = $resource;
-    }
-
     /**
      * @return ResourceInterface
      */
@@ -98,14 +90,6 @@ public function getResource()
         return $this->resource;
     }
 
-    /**
-     * @param AbstractPluginManager $inputFilterManager
-     */
-    public function setInputFilterManager(AbstractPluginManager $inputFilterManager)
-    {
-        $this->inputFilterManager = $inputFilterManager;
-    }
-
     /**
      * @return AbstractPluginManager
      */

diff --git a/tests/ZfrRestTest/Mvc/Controller/Event/HydrationEventTest.php b/tests/ZfrRestTest/Mvc/Controller/Event/HydrationEventTest.php
@@ -67,31 +67,21 @@ public function testSetGetHydrator()
         $this->assertSame($hydrator, $event->getHydrator());
     }
 
-    public function testSetGetResource()
+    public function testGetResource()
     {
-        $resourceA       = $this->getMock('ZfrRest\Resource\ResourceInterface');
-        $resourceB       = $this->getMock('ZfrRest\Resource\ResourceInterface');
+        $resource        = $this->getMock('ZfrRest\Resource\ResourceInterface');
         $hydratorManager = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
-        $event           = new HydrationEvent($resourceA, $hydratorManager);
-
-        $this->assertSame($resourceA, $event->getResource());
-
-        $event->setResource($resourceB);
+        $event           = new HydrationEvent($resource, $hydratorManager);
 
-        $this->assertSame($resourceB, $event->getResource());
+        $this->assertSame($resource, $event->getResource());
     }
 
     public function testSetGetHydratorManager()
     {
-        $resource         = $this->getMock('ZfrRest\Resource\ResourceInterface');
-        $hydratorManagerA = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
-        $hydratorManagerB = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
-        $event            = new HydrationEvent($resource, $hydratorManagerA);
-
-        $this->assertSame($hydratorManagerA, $event->gethydratorManager());
-
-        $event->sethydratorManager($hydratorManagerB);
+        $resource        = $this->getMock('ZfrRest\Resource\ResourceInterface');
+        $hydratorManager = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
+        $event           = new HydrationEvent($resource, $hydratorManager);
 
-        $this->assertSame($hydratorManagerB, $event->gethydratorManager());
+        $this->assertSame($hydratorManager, $event->gethydratorManager());
     }
 }
diff --git a/tests/ZfrRestTest/Mvc/Controller/Event/ValidationEventTest.php b/tests/ZfrRestTest/Mvc/Controller/Event/ValidationEventTest.php
@@ -67,31 +67,21 @@ public function testSetGetInputFilter()
         $this->assertSame($inputFilter, $event->getInputFilter());
     }
 
-    public function testSetGetResource()
+    public function testGetResource()
     {
-        $resourceA          = $this->getMock('ZfrRest\Resource\ResourceInterface');
-        $resourceB          = $this->getMock('ZfrRest\Resource\ResourceInterface');
+        $resource           = $this->getMock('ZfrRest\Resource\ResourceInterface');
         $inputFilterManager = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
-        $event              = new ValidationEvent($resourceA, $inputFilterManager);
-
-        $this->assertSame($resourceA, $event->getResource());
-
-        $event->setResource($resourceB);
+        $event              = new ValidationEvent($resource, $inputFilterManager);
 
-        $this->assertSame($resourceB, $event->getResource());
+        $this->assertSame($resource, $event->getResource());
     }
 
-    public function testSetGetInputFilterManager()
+    public function testGetInputFilterManager()
     {
-        $resource            = $this->getMock('ZfrRest\Resource\ResourceInterface');
-        $inputFilterManagerA = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
-        $inputFilterManagerB = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
-        $event               = new ValidationEvent($resource, $inputFilterManagerA);
-
-        $this->assertSame($inputFilterManagerA, $event->getInputFilterManager());
-
-        $event->setInputFilterManager($inputFilterManagerB);
+        $resource           = $this->getMock('ZfrRest\Resource\ResourceInterface');
+        $inputFilterManager = $this->getMock('Zend\ServiceManager\AbstractPluginManager');
+        $event              = new ValidationEvent($resource, $inputFilterManager);
 
-        $this->assertSame($inputFilterManagerB, $event->getInputFilterManager());
+        $this->assertSame($inputFilterManager, $event->getInputFilterManager());
     }
 }