Allow to set controller behaviors per controller #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
bakura10
added a commit
that referenced
this pull request
Feb 21, 2014
Allow to set controller behaviors per controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #125
ping @danizord @Ocramius
As said, this PR removes completely the controller behavior options (as a consequence, I also removed for now the options that allowed to preserve keys for error messages, as I'm not satisfied with the ControllerBehaviour naming anymore, as most controller behaviors were moved inside the controller).
The big +1 is that it now allows to set those behaviors by controller, which offers a big boost in flexibility. However, I need now to type hint controller in method handlers for AbstractRestfulController from ZfrRest. I'm not sure this is really a problem, as I can't see someone wanting to use ZfrRest method handlers without using the ZfrRest controller.
Tests were not updated yet, I'm waiting for your review guys :)