Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Standard filter for serialization controller output #90

Closed
wants to merge 1 commit into from

Conversation

Orkin
Copy link
Member

@Orkin Orkin commented Sep 11, 2013

As explain in #17, I'm starting to work on a hydrator for add ExtractionDepth fonctionnality.

I have problem to retrieve classMetadata in new hydrator for check level of extraction needed

use Zend\Paginator\Paginator;
use DoctrineModule\Stdlib\Hydrator\DoctrineObject;

class ZfrRestHydrator extends DoctrineObject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like the added complexity to an already super-complex hydrator… I'll try to carefully review this later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I fully agree with that. Instead of handling extraction, just pull in an existing hydrator (via hydrator interface) and then iterate over the extracted values (or the values to hydrate) instead.

That's where you'd need the metadata

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.33%) when pulling 1981946 on Orkin:zfr-hydrator into 2866dc1 on zf-fr:master.

@bakura10 bakura10 closed this Dec 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants