Make the introduced performance optimization for PluginLoader optional #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
falkenhawk
commented
May 6, 2019
•
falkenhawk
commented
- restore original PluginLoader behavior by default
- introduce static Zend_Loader_PluginLoader::useFallbackLoader(false) toggle to disable the fallback and depend solely on composer's autoloader (for performance) - if your code structure supports that ( Revert "optimize loading plugins - use only composer autoloader" #2 (comment) )
- restore original PluginLoader behavior by default - introduce static Zend_Loader_PluginLoader::useFallbackLoader(false) toggle to disable the fallback and depend solely on composer's autoloader (for performance) - if your code structure supports that
|
LGTM as is backward compatible |
|
thank you for addressing this in a timely manner! |
falkenhawk
added a commit
that referenced
this pull request
May 23, 2019
#4) - restore original PluginLoader behavior by default - introduce static Zend_Loader_PluginLoader::useFallbackLoader(false) toggle to disable the fallback and depend solely on composer's autoloader (for performance) - if your code structure supports that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.