Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend XML - fix version comparison operator #26

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

partikus
Copy link
Contributor

@partikus partikus commented Sep 28, 2020

This PR fixes an invalid operator. gte is not supported.

If the third optional operator argument is specified, test for a particular relationship. The possible operators are: <, lt, <=, le, >, gt, >=, ge, ==, =, eq, !=, <>, ne respectively.

https://www.php.net/manual/en/function.version-compare.php

(cherry picked from commit 8f8e4f5)
@partikus partikus self-assigned this Sep 28, 2020
@glensc
Copy link
Contributor

glensc commented Sep 28, 2020

@partikus: describe the problem you are solving. i.e why should maintainers accept this change? also as this is repo of all components, what component this affects? (update title).

@partikus partikus changed the title fix version comparison operator Zend XML - fix version comparison operator Sep 29, 2020
@partikus partikus added the bug Something isn't working label Sep 29, 2020
@partikus
Copy link
Contributor Author

@glensc I hope the PR's initial comment answering your question.

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @partikus !

@falkenhawk
Copy link
Member

Unrelated to this change, php 5.3 travis build started to fail, https://travis-ci.com/github/zf1s/zf1/jobs/392057787

$ composer install
Loading composer repositories with package information
                                           
  [Composer\Downloader\TransportException]  
  Peer fingerprint did not match            

🤔

@falkenhawk
Copy link
Member

Last successful build https://travis-ci.com/github/zf1s/zf1/jobs/375326855 used

Composer version 1.10.10 2020-08-03 11:35:19

Now it's using

Composer version 1.10.13 2020-09-09 11:46:34

It could be that there is a bug in composer itself.. I don't think they stopped supporting php 5.3 just yet in v1

@glensc
Copy link
Contributor

glensc commented Sep 29, 2020

I just checked the other variant of this, and it's broken there too:

@glensc
Copy link
Contributor

glensc commented Sep 29, 2020

"Peer fingerprint did not match" sounds like a temporary error. Try retrying, try clearing Travis caches. If that doesn't work, report to the composer project, or Travis support.

@falkenhawk
Copy link
Member

"Peer fingerprint did not match" sounds like a temporary error. Try retrying, try clearing Travis caches. If that doesn't work, report to the composer project, or Travis support.

Today it worked 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants