This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Error views hot fix #136
Merged
Error views hot fix #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,7 +52,8 @@ if (! empty($this->reason)) : | |||
|
|
|||
| <?php if (! empty($this->display_exceptions)) : ?> | |||
|
|
|||
| <?php if (isset($this->exception) && $this->exception instanceof Exception) : ?> | |||
| <?php if (isset($this->exception) | |||
| && ($this->exception instanceof \Exception || $this->exception instanceof \Error)) : ?> | |||
There was a problem hiding this comment.
Elsewhere we check first for Throwable, than Exception, which optimizes for PHP 7 (where both exception and errors are types of Throwable). I'll make that change on merge.
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception in error views could be
\Exceptionor\Errorinstance