This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
Remove include of application configuration
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per zfcampus#24, `include` can be problematic on applications that use ENV variables or constants inside their `application.config.php`. This patch removes the `include` in favor of doing static analysis via regexp; it's far from perfect, but will work in the majority of use cases. `include` is still required, however, if you want to selectively enable modules. CS fixes - Updated php-cs-fixer - php-cs-fixer is being too aggressive on `include` statements; moved include out of constructor call to prevent fixer changes in the future.
weierophinney
added a commit
that referenced
this pull request
Jul 15, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #24,
includecan be problematic on applications that use ENV variablesor constants inside their
application.config.php. This patch removes theincludein favor of doing static analysis via regexp; it's far from perfect,but will work in the majority of use cases.
includeis still required, however, if you want to selectively enablemodules.