This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
fix filtering of joined/referenced fields, add custom types support #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add doctrine custom types support
TomHAnderson
suggested changes
May 7, 2018
| $format = null; | ||
| if (isset($option['format'])) { | ||
| $format = $option['format']; | ||
| } | ||
|
|
||
| $value = $this->typeCastField($metadata, $option['field'], $option['value'], $format); | ||
| $value = $this->typeCastField($typeCastMetaData, $typeCastFieldName, $option['value'], $format); |
There was a problem hiding this comment.
Metadata is a single word in Doctrine https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/metadata-drivers.html
|
|
||
| protected function getTypeCastParams($queryBuilder, $metadata, $fieldName, $alias) | ||
| { | ||
| /** @var \Doctrine\ORM\Mapping\ClassMetadata $metadata */ |
There was a problem hiding this comment.
These comment docs should go above the function, yes?
|
@gegok We need tests to cover these changes and demonstrate the described issues. |
|
Closing, due to lack of tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeCastField() is not used correctly for reference fields and joined entity fields
because of wrong $metadata object usage
filters doesn't support custom data types
added $fieldType passing to setParameter();