Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Extract type cast behaviour #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zluiten
Copy link

@zluiten zluiten commented Sep 16, 2019

By extracting the type casting to its own class it can be easily replaced when needed. Preferring composition over inheritance etc.

It becomes better testable as well.

I tried to keep BC by proxying to the TypeCaster and instantiating the TypeCaster in the AbstractFilter::getTypeCaster() method when not set in case FilterManager::filter() method is overridden.

@zluiten zluiten changed the title Extract type cast behaviour and add support for the immutable datetim… Extract type cast behaviour Sep 16, 2019
@zluiten zluiten force-pushed the feature/extract-type-casting branch 9 times, most recently from 9f14821 to 8c26609 Compare September 16, 2019 11:51
@coveralls
Copy link

coveralls commented Sep 16, 2019

Coverage Status

Coverage decreased (-66.2%) to 14.427% when pulling b20a1a0 on netiul:feature/extract-type-casting into cca97a6 on zfcampus:master.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas-api-tools/api-tools-doctrine-querybuilder; a new issue has been opened at laminas-api-tools/api-tools-doctrine-querybuilder#1.

@weierophinney
Copy link
Member

This repository has been moved to laminas-api-tools/api-tools-doctrine-querybuilder. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas-api-tools/api-tools-doctrine-querybuilder to another directory.
  • Copy the files from the second bullet point to the clone of laminas-api-tools/api-tools-doctrine-querybuilder.
  • In your clone of laminas-api-tools/api-tools-doctrine-querybuilder, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants