This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Fixed the receive code page #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($this->code) { | ||
| printf("<h2>The authentication code is %s</h2>", $this->code); | ||
| printf("<p>Use this code to request an access token.</p>"); | ||
| printf("For instance, using <a href=\"https://github.com/jkbr/httpie\">HTTPie</a>:</p> "); | ||
| printf( | ||
| "<p>http POST https://%s/oauth grant_type=authorization_code code=%s redirect_uri=%s client_id=testclient client_secret=testpass</p>", | ||
| "<p>http POST %s://%s/oauth grant_type=authorization_code code=%s redirect_uri=%s client_id=testclient client_secret=testpass</p>", | ||
| $http, | ||
| $_SERVER['HTTP_HOST'], |
There was a problem hiding this comment.
I'm thinking that this should be:
"<p>http POST %s grant_type=authorization_code code=%s redirect_uri=%s client_id=testclient client_secret=testpass</p>",
$this->serverUrl('/oauth'),
$this->code,
'/oauth/receivecode'The serverUrl() view helper will properly determine the scheme and authority, and if you pass a path, it will use that path to generate the fully qualified URI with scheme and authority.
Please do that throughout this patch.
There was a problem hiding this comment.
@weierophinney ok, changed. Thanks!
|
@nuxwin because it's required by curl, I just tested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #111