Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support python 3.12 #76

Merged
merged 5 commits into from
Apr 13, 2024
Merged

chore: support python 3.12 #76

merged 5 commits into from
Apr 13, 2024

Conversation

ikrommyd
Copy link
Contributor

@ikrommyd ikrommyd commented Apr 13, 2024

Support Python 3.12 with newest zfit release

Checklist

  • change approved
  • implementation finished
  • correct namespace imported
  • tests added
  • CHANGELOG updated

@ikrommyd ikrommyd changed the title support python 3.12 chore: support python 3.12 Apr 13, 2024
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonas-eschle
Copy link
Contributor

Can be merged from my side! After the merge, we can make a release. Familiar with it?
The cd (it .github/cd.yml) triggers the deployment phase if a release has been made on GH. Making a release is best in conjunction with a tag, i.e. you can create a release and tag on github, or create a release (adjust the changelog accordingly) and then make a release here. This should trigger pypi deployment.

A step-by-step guide is here: https://github.com/zfit/zfit-development/wiki/Release-strategy

@jonas-eschle
Copy link
Contributor

Feel free to make a new release, if you have questions, just ask, otherwise just go ahead and I am looking forward for the next (0.7.0) release out ;)

@ikrommyd ikrommyd merged commit 4b2333d into develop Apr 13, 2024
12 checks passed
@ikrommyd ikrommyd deleted the ikrommyd/support-py-312 branch April 13, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants