Smaller fixes from branch serialization_2020 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of __init__() directly is discouraged, use constructor methods instead.
The abstract property shape() is already declared on ZfitParameter.
|
Proposition: Combine BaseComposedParameter and ComposedParameter into one class. What is the benefit of having these two separated? |
SebastianJL
force-pushed
the
serialization_2020
branch
from
8c6db7c
to
0987c98
Compare
|
yeah, that's true actually, I think the idea was to use it as base also for Complex and similar. Let's merge the two PRs though and look again at it later on, okay (otherwise we'll have many conflicts I fear)? maybe it's worth with the dumping to have this extra class and let complex etc inherit from it |
Deleted obsolete kwargs parameter in ComplexParameter.from_polar().
jonas-eschle
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some smaller fixes and improvements while studying the file parameter.py.
One bigger change is to change ZfitParameter.shape from a property that raises NotImplementedError to an abstract parameter.
Added Tests