Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Kernel builtins broken in 0.6.5.2? #481

Closed
gcs-github opened this issue Oct 11, 2015 · 3 comments
Closed

Kernel builtins broken in 0.6.5.2? #481

gcs-github opened this issue Oct 11, 2015 · 3 comments

Comments

@gcs-github
Copy link

Hello!

I stumbled upon an oddity today patching my kernel with SPL/ZFS 0.6.5.2.

Using ./copy-builtin on a configured kernel tree works normally, and I'm then able to compile my kernel with SPL and then ZFS built-in without a hitch.

But, if after the ./copy-builtin succeeds I issue a "make clean" or a "make distclean" in my kernel tree so I can distribute the patched kernel source or create different kernel configurations, in any subsequent kernel build attempt, SPL will fail to compile during the regular kernel build process, with the following message:

make[2]: *** No rule to make target 'spl/spl/spl-proc.o', needed by 'spl/spl/spl.o'.  Stop.
scripts/Makefile.build:403: recipe for target 'spl/spl' failed
make[1]: *** [spl/spl] Error 2
Makefile:949: recipe for target 'spl' failed
make: *** [spl] Error 2

This is with a vanilla Linux 4.2.3 source tree.

Linux kernel's "make clean" deleting more than it should, maybe?

@behlendorf
Copy link
Contributor

It certainly looks that way. Thanks for filing this, we'll look in to it time permitting.

@berney
Copy link

berney commented Nov 23, 2015

I had the same symptoms. In the Makefiles was a src= and obj= lines pointing to portage tmp dirs. I commented them out and then make would work.

behlendorf added a commit to behlendorf/spl that referenced this issue Dec 2, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#481
Issue openzfs#498
behlendorf added a commit to behlendorf/zfs that referenced this issue Dec 2, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Requires-spl: refs/pull/503/head
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
behlendorf added a commit that referenced this issue Dec 2, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #481
Issue #498
behlendorf added a commit to behlendorf/zfs that referenced this issue Dec 2, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
@behlendorf
Copy link
Contributor

Merged:

4e6f996 Fix --enable-linux-builtin

ryao pushed a commit to ryao/spl that referenced this issue Dec 3, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#481
Issue openzfs#498
ryao pushed a commit to ryao/zfs that referenced this issue Dec 3, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
goulvenriou pushed a commit to Alyseo/zfs that referenced this issue Dec 8, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
behlendorf added a commit that referenced this issue Dec 24, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #481
Issue #498
behlendorf added a commit to openzfs/zfs that referenced this issue Dec 24, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants