Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Linux 4.14 compat: vfs_read/vfs_write => kernel_read/kernel_write #666

Closed
wants to merge 1 commit into from
Closed

Linux 4.14 compat: vfs_read/vfs_write => kernel_read/kernel_write #666

wants to merge 1 commit into from

Conversation

pritambaral
Copy link

@pritambaral pritambaral commented Nov 13, 2017

Fixes #656
Closes #659 (the author of which excused himself from working on it)

This also incorporates some of the feedback on #659.

Dummy PR against ZFS to run automated tests: openzfs/zfs#6861

kernel_read/kernel_write have always wrapped vfs_read/vfs_write,
respectively, with a safety net around casting to user pointers too.
kernel_read was always exported, going back to Linux's very first git
check-in. kernel_write was exported in 3.9.

Linux 4.14 unexported vfs_read & vfs_write, after replacing all modular
calls to these functions with kernel_read & kernel_write, respectively.

Linux 4.14 also changed the signatures of kernel_read & kernel_write to
more closely match vfs_read & vfs_write.

Signed-off-by: Pritam Baral <pritam@pritambaral.com>
@bmaxa
Copy link

bmaxa commented Nov 14, 2017

This patch works ok on my install. I can mount files on older kernels.

@behlendorf
Copy link
Contributor

Replaced by #667. @pritambaral thanks for refreshing this, I've taken your updated version and reworked it to be more strict about the prototypes. Can you please look it over.

@behlendorf behlendorf closed this Nov 14, 2017
@pritambaral pritambaral deleted the fix/vfs_read_write branch November 27, 2017 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants