Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

spl: Unknown symbol vfs_read (err 0) #656

Closed
krichter722 opened this issue Oct 6, 2017 · 2 comments
Closed

spl: Unknown symbol vfs_read (err 0) #656

krichter722 opened this issue Oct 6, 2017 · 2 comments

Comments

@krichter722
Copy link

After installing Ubuntu 4.14-rc3 mainline kernel for verification of an issue, I noticed that after building and installing spl and zfs with git clean -x -f -d && ./autogen.sh && ./configure && make && sudo make install && sudo make deb-kmod && sudo dpkg -i *.deb like I do on standard Ubuntu kernels (+ removing /lib/modules/[version]/kernel/zfs and sudo depmod -a which I don't have to do for mainline kernels because there's no /lib/modules/[version]/kernel/zfs) modprobe zfs fails with

modprobe: ERROR: could not insert 'zfs': Unknown symbol in module, or unknown parameter (see dmesg)

and dmesg contains

[  941.174786] spl: Unknown symbol vfs_write (err 0)
[  941.174865] spl: Unknown symbol vfs_read (err 0)

I'm not very eager to use the kernel, I just wanted to bring this to the attention of the devs, but I can re-install it and provide further information in case you can't reproduce the issue.

experienced with spl 0.7.0-13_ge8474f9a and 0.7.0-99_g39f56627a on Ubuntu 17.04 amd64
@loli10K
Copy link
Contributor

loli10K commented Oct 7, 2017

torvalds/linux@bd8df82: fs: unexport vfs_read and vfs_write

No modular users left. Given that they take user pointers there is no
good reason to export it to drivers to start with.

@behlendorf
Copy link
Contributor

Initial patch in #659 for review.

@oberon-manjaro oberon-manjaro mentioned this issue Oct 18, 2017
Closed
@sarangnemo sarangnemo mentioned this issue Oct 23, 2017
Closed
sarangnemo added a commit to sarangnemo/anbox that referenced this issue Oct 29, 2017
@sarangnemo
replace deprecated vfs_read with kernel_read
f633d64 
See anbox#486 and related issue with ashmem and ZFS:
openzfs/spl#656
@sarangnemo sarangnemo mentioned this issue Oct 29, 2017
Merged
This was referenced Nov 13, 2017
Closed
Closed
@sanguinariojoe sanguinariojoe mentioned this issue Nov 14, 2017
Closed
@behlendorf behlendorf mentioned this issue Nov 14, 2017
Closed
13 tasks
tonyhutter pushed a commit to tonyhutter/spl that referenced this issue Nov 21, 2017
@behlendorf @tonyhutter
Linux 4.14 compat: vfs_read & vfs_write
8a89f29 
The kernel_read & kernel_write functions have always wrapped the
vfs_read & vfs_write functions respectively.  However, they could
not be used by vn_rdwr() since the offset wasn't passed as a
pointer.  This prevented us from being able to properly update
the file offset.

Linux 4.14 unexported vfs_read & vfs_write but also changed the
signature of kernel_read & kernel_write to provide the needed
functionality.  Use these updated functions when available.

Reviewed-by: Pritam Baral <pritam@pritambaral.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#656 
Closes openzfs#667
@demizer demizer mentioned this issue Dec 3, 2017
Closed
vasishath added a commit to vasishath/anbox that referenced this issue Dec 16, 2017
@vasishath
[PATCH] replace deprecated vfs_read with kernel_read
5ac2334 
See anbox/anbox#486 and related issue with ashmem and ZFS:
openzfs/spl#656
@BGFWDev BGFWDev mentioned this issue May 9, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@behlendorf @krichter722 @loli10K