VERIFY(0 == dmu_buf_hold_array()) in dmu_write() #1440
Comments
|
I tiny debug patch to report the offending error code in the VERIFY error message. diff --git a/module/zfs/dmu.c b/module/zfs/dmu.c
index e856356..de946fd 100644
--- a/module/zfs/dmu.c
+++ b/module/zfs/dmu.c
@@ -787,7 +787,7 @@ dmu_write(objset_t *os, uint64_t object, uint64_t offset, ui
if (size == 0)
return;
- VERIFY(0 == dmu_buf_hold_array(os, object, offset, size,
+ VERIFY3S(0, ==, dmu_buf_hold_array(os, object, offset, size,
FALSE, FTAG, &numbufs, &dbp));
for (i = 0; i < numbufs; i++) { |
This was referenced Oct 3, 2014
behlendorf
added a commit
to behlendorf/zfs
that referenced
this issue
Oct 3, 2014
This is a debug patch designed to ensure an error code is logged to the console when this VERIFY() is hit. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#1440
behlendorf
added a commit
to behlendorf/zfs
that referenced
this issue
Oct 8, 2014
This is a debug patch designed to ensure an error code is logged to the console when this VERIFY() is hit. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ned Bass <bass6@llnl.gov> Issue openzfs#1440
|
The additional debugging has been merged. If this issue occurs again the error code will be logged. |
ryao
pushed a commit
to ryao/zfs
that referenced
this issue
Nov 29, 2014
This is a debug patch designed to ensure an error code is logged to the console when this VERIFY() is hit. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ned Bass <bass6@llnl.gov> Issue openzfs#1440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Andrei Mikhailovsky wrote:
I was wondering if someone could help me with sorting out an issue when trying to mount a zfs filesystem.
I had a disk failure on a raidz1. The disk has been replaced, resilvered and zpool scrub has been ran. Unfortunately, it was unable to repair the errors and there are still a large number of errors in the zfs pool. Despite that I am still able to mount 2 out of 3 filesystems. The trouble is majority of important data is on a 3rd filesystem which I am unable to mount. I get an SPL PANIC. Please see below the information:
Server is Ubuntu Server 12.10 64bit with up to date patch level and zfs version 0.6.1 installed from the stable ppa.
ZFS Pool details (compression = lz4; deduplication = off): zpool status pool: zfs-mirror state: ONLINE status: One or more devices has experienced an error resulting in data corruption. Applications may be affected. action: Restore the file in question if possible. Otherwise restore the entire pool from backup. see: http://zfsonlinux.org/msg/ZFS-8000-8A scan: scrub repaired 0 in 6h33m with 15722 errors on Thu May 2 03:44:56 2013 config: NAME STATE READ WRITE CKSUM zfs-mirror ONLINE 0 0 31.0K raidz1-0 ONLINE 0 0 63.4K scsi-20004d927fffff800 ONLINE 0 0 0 scsi-20004d927fffff810 ONLINE 0 0 0 scsi-20004d927fffff820 ONLINE 0 0 0 scsi-20004d927fffff830 ONLINE 0 0 0 scsi-20004d927fffff840 ONLINE 0 0 0 scsi-20004d927fffff850 ONLINE 0 0 0 scsi-20004d927fffff860 ONLINE 0 0 0 sdh ONLINE 0 0 0 errors: 15723 data errors, use '-v' for a listAs per my conversation with couple of guys on the IRC #zfsonlinux channel I have been suggested to try booting into the latest FreeBSD and also OpenIndiana and see if the filesystem in question could me mounted. I have done zpool export on the ubuntu server and tried to import it from a bootable live usb stick. The FreeBSD 9.1 doesn't have support for the zfs v5000, so I was unable to import it. The OpenIndiana live CD didn't have support for the lz4 compression, so once again, was unable to import the pool.
I have tried booting into SmartOS, but even though the pool was visible and supported by the version of zfs that came with the SmartOS I had an OS panic and a reboot when trying to import the pool with zpool import .
I am running out of ideas on what else to try and I really need to get the data from that partition. Whatever is salvageable. Is there any other way I could get to the data? I am happy to try any patches that could address the SPL Panic or do more debugging using your instructions.
Many thanks in advance for your suggestions.
Andrei
The text was updated successfully, but these errors were encountered: