Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 5.0: macro "access_ok" passed 3 arguments, but takes just 2 #8261

Closed
tonyhutter opened this issue Jan 10, 2019 · 0 comments
Closed

Linux 5.0: macro "access_ok" passed 3 arguments, but takes just 2 #8261

tonyhutter opened this issue Jan 10, 2019 · 0 comments
Assignees
@tonyhutter
Labels
Type: Building Indicates an issue related to building binaries

Comments

@tonyhutter
Copy link
Contributor

System information

Type Version/Name
Distribution Name Fedora
Distribution Version 30 (rawhide)
Linux Kernel 5.0.0-0.rc1.git0.1.fc30.x86_64
Architecture x86-64
ZFS Version master
SPL Version master

Describe the problem you're observing

The 5.0 kernel dropped the type argument to access_ok()

- access_ok(type, addr, size)
+ access_ok(addr, size)

https://lkml.org/lkml/2019/1/4/418

Describe how to reproduce the problem

Build master in rawhide

Include any warning/errors/backtraces from the system logs

/home/hutter/current_kernel_time64/module/zcommon/zfs_uio.c: In function ‘uiomove_iov’:
/home/hutter/current_kernel_time64/module/zcommon/zfs_uio.c:85:37: error: macro "access_ok" passed 3 arguments, but takes just 2
          (iov->iov_base + skip), cnt)) {
                                     ^
/home/hutter/current_kernel_time64/module/zcommon/zfs_uio.c:84:11: error: ‘access_ok’ undeclared (first use in this function)
      if (!access_ok(VERIFY_READ,
           ^~~~~~~~~
@tonyhutter tonyhutter self-assigned this Jan 10, 2019
@tonyhutter tonyhutter added the Type: Building Indicates an issue related to building binaries label Jan 10, 2019
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter:
180381b 
access_ok no longer needs a 'type' paramete in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter:
36fe682 
access_ok no longer needs a 'type' paramete in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter:
efcecda 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter:
c14fed5 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Jan 16, 2019
@tonyhutter @behlendorf
Linux 5.0: access_ok() drops 'type' parameter:
38e30be 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter:
73827c5 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
@tonyhutter tonyhutter mentioned this issue Jan 17, 2019
Closed
12 tasks
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter:
5de4231 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter
57002a1 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter
871d188 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter
cfcd883 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 23, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter
e65d362 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 25, 2019
@tonyhutter
Linux 5.0: access_ok() drops 'type' parameter
2f108d7 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 30, 2019
@tonyhutter
Linux 5.0 compat: access_ok() drops 'type' parameter
916bb5f 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8261
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 12, 2019
@tonyhutter
Linux 5.0 compat: access_ok() drops 'type' parameter
89cd236 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8261
tonyhutter added a commit that referenced this issue Mar 4, 2019
@tonyhutter
Linux 5.0 compat: access_ok() drops 'type' parameter
edc2675 
access_ok no longer needs a 'type' parameter in the 5.0 kernel.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #8261
@awonnacott awonnacott mentioned this issue Jul 26, 2019
Merged
Anthony96922 added a commit to Anthony96922/mt7601u-ap that referenced this issue Aug 17, 2019
@Anthony96922
Fix for Linux 5.0
3a76c91 
See openzfs/zfs#8261
@erotavlasme erotavlasme mentioned this issue Aug 29, 2019
Open
RussellTaylor83 added a commit to RussellTaylor83/rtl88x2bu-driver that referenced this issue Oct 20, 2019
@RussellTaylor83
Fixed build errors, one following the pull request here whitebatman2/…
60fd8b9 
…rtl8821CU#14, the other following the issue here openzfs/zfs#8261.
@jonyluke jonyluke mentioned this issue Dec 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyhutter tonyhutter

Labels
Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonyhutter