Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.16 kernel: Use correct *_dec_and_test() #7211

Merged
merged 1 commit into from Feb 22, 2018
Merged

4.16 kernel: Use correct *_dec_and_test() #7211

merged 1 commit into from Feb 22, 2018

Conversation

tonyhutter
Copy link
Contributor

Description

Use refcount_dec_and_test() on 4.16+ kernels and atomic_dec_and_test() on older kernels. https://lwn.net/Articles/714974/

This allows ZFS to compile on 4.16 kernels.

Motivation and Context

Closes: #7179

How Has This Been Tested?

Built on 4.16.0-999, 4.11.9, and 2.6.32 kernels.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@tonyhutter
4.16 kernel: Use correct *_dec_and_test()
fd4d275 
Use refcount_dec_and_test() on 4.16+ kernels, atomic_dec_and_test()
on older kernels.  https://lwn.net/Articles/714974/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#7179
@codecov
Copy link

codecov bot commented Feb 22, 2018 •
edited

Codecov Report

Merging #7211 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7211      +/-   ##
==========================================
+ Coverage   76.23%   76.41%   +0.17%     
==========================================
  Files         327      327              
  Lines      103833   103767      -66     
==========================================
+ Hits        79156    79292     +136     
+ Misses      24677    24475     -202
Flag Coverage Δ
#kernel 76.21% <ø> (-0.1%) ⬇️
#user 65.79% <ø> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09302a4...fd4d275. Read the comment docs.

@behlendorf behlendorf merged commit a5369b6 into openzfs:master Feb 22, 2018
@behlendorf behlendorf added this to To do in 0.7.7 Feb 23, 2018
@tonyhutter tonyhutter moved this from To do to In progress in 0.7.7 Mar 6, 2018
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Mar 7, 2018
@tonyhutter
Linux 4.16 compat: use correct *_dec_and_test()
074cffe 
Use refcount_dec_and_test() on 4.16+ kernels, atomic_dec_and_test()
on older kernels.  https://lwn.net/Articles/714974/

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#7179 
Closes: openzfs#7211
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Mar 7, 2018
@ryao @tonyhutter
zfs-0.7.7 squashed patchset
3c93490 
This is a squashed patchset for zfs-0.7.7.  The individual commits are
in the tonyhutter:zfs-0.7.7-hutter branch.  I squashed the commits so
that buildbot wouldn't have to run against each one, and because
github/builbot seem to have a maximum limit of 30 commits they can
test from a PR.

- Linux 4.16 compat: get_disk_and_module() openzfs#7264
- Change checksum & IO delay ratelimit values openzfs#7252
- Increment zil_itx_needcopy_bytes properly openzfs#6988  openzfs#7176
- Fix some typos openzfs#7237
- Fix zpool(8) list example to match actual format openzfs#7244
- Add SMART self-test results to zpool status -c openzfs#7178
- Add scrub after resilver zed script openzfs#4662  openzfs#7086
- Fix free memory calculation on v3.14+ openzfs#7170
- Report duration and error in mmp_history entries openzfs#7190
- Do not initiate MMP writes while pool is suspended openzfs#7182
- Linux 4.16 compat: use correct *_dec_and_test() openzfs#7179  openzfs#7211
- Allow modprobe to fail when called within systemd openzfs#7174
- Add SMART attributes for SSD and NVMe openzfs#7183  openzfs#7193
- Correct count_uberblocks in mmp.kshlib openzfs#7191
- Fix config issues: frame size and headers openzfs#7169
- Clarify zinject(8) explanation of -e openzfs#7172
- OpenZFS 8857 - zio_remove_child() panic due to already destroyed
  parent zio openzfs#7168
- 'zfs receive' fails with "dataset is busy" openzfs#7129  openzfs#7154
- contrib/initramfs: add missing conf.d/zfs openzfs#7158
- mmp should use a fixed tag for spa_config locks openzfs#6530  openzfs#7155
- Handle zap_add() failures in mixed case mode openzfs#7011 openzfs#7054
- Fix zdb -ed on objset for exported pool openzfs#7099 openzfs#6464
- Fix zdb -E segfault openzfs#7099
- Fix zdb -R decompression openzfs#7099  openzfs#4984
- Fix racy assignment of zcb.zcb_haderrors openzfs#7099
- Fix zle_decompress out of bound access openzfs#7099
- Fix zdb -c traverse stop on damaged objset root openzfs#7099
- Linux 4.11 compat: avoid refcount_t name conflict openzfs#7148
- Linux 4.16 compat: inode_set_iversion() openzfs#7148
- OpenZFS 8966 - Source file zfs_acl.c, function zfs_aclset_common
  contains a use after end of the lifetime of a local variable openzfs#7141
- Remove deprecated zfs_arc_p_aggressive_disable openzfs#7135
- Fix default libdir for Debian/Ubuntu openzfs#7083  openzfs#7101
- Bug fix in qat_compress.c for vmalloc addr check openzfs#7125
- Fix systemd_ RPM macros usage on Debian-based distributions openzfs#7074
  openzfs#7100
- Emit an error message before MMP suspends pool openzfs#7048
- ZTS: Fix create-o_ashift test case openzfs#6924  openzfs#6977
- Fix --with-systemd on Debian-based distributions (openzfs#6963) openzfs#6591  openzfs#6963
- Remove vn_rename and vn_remove dependency openzfs/spl#648 openzfs#6753
- Add support for "--enable-code-coverage" option openzfs#6670
- Make "-fno-inline" compile option more accessible openzfs#6605
- Add configure option to enable gcov analysis openzfs#6642
- Implement --enable-debuginfo to force debuginfo openzfs#2734
- Make --enable-debug fail when given bogus args openzfs#2734

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-spl: refs/pull/690/head
@tonyhutter tonyhutter mentioned this pull request Mar 7, 2018
Closed
13 tasks
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Mar 12, 2018
@tonyhutter
Linux 4.16 compat: use correct *_dec_and_test()
93501df 
Use refcount_dec_and_test() on 4.16+ kernels, atomic_dec_and_test()
on older kernels.  https://lwn.net/Articles/714974/

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#7179 
Closes: openzfs#7211
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Mar 13, 2018
@tonyhutter
Linux 4.16 compat: use correct *_dec_and_test()
3d71f91 
Use refcount_dec_and_test() on 4.16+ kernels, atomic_dec_and_test()
on older kernels.  https://lwn.net/Articles/714974/

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#7179 
Closes: openzfs#7211
tonyhutter added a commit that referenced this pull request Mar 19, 2018
@tonyhutter
Linux 4.16 compat: use correct *_dec_and_test()
e5ba614 
Use refcount_dec_and_test() on 4.16+ kernels, atomic_dec_and_test()
on older kernels.  https://lwn.net/Articles/714974/

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: #7179
Closes: #7211
teknoman117 pushed a commit to teknoman117/zfs that referenced this pull request Jun 7, 2018
@tonyhutter @teknoman117
Linux 4.16 compat: use correct *_dec_and_test()
bfc01f7 
Use refcount_dec_and_test() on 4.16+ kernels, atomic_dec_and_test()
on older kernels.  https://lwn.net/Articles/714974/

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#7179 
Closes: openzfs#7211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@dinatale2 dinatale2 dinatale2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
0.7.7
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.16 kernel: atomic_dec_and_test() changed
3 participants
@tonyhutter @behlendorf @dinatale2