Fedora 28: Fix "Macro %_dracutdir has empty body" #7328
Conversation
tonyhutter
force-pushed
the
fedora28-dracutdir
branch
from
6db802c
to
46e94b0
Compare
There was a problem hiding this comment.
The Fedora Rawhide build failure here is because the full-debug kernel is installed by default the latest kernel-devel package doesn't include objtool. Why don't we resolve this by switching to the This seems to be a regression in the Fedora kernel packaging which they'll hopefully sort out quickly.nodebug kernel which is what will be used when in the final Fedora release.
config/zfs-build.m4
Outdated
| dnl # | ||
| dnl # ./configure --with-config=srpm | ||
| dnl # | ||
| AS_IF([test "$dracutdir" != "" ], [ |
There was a problem hiding this comment.
How about using test -n here instead.
Codecov Report
@@ Coverage Diff @@
## master #7328 +/- ##
==========================================
- Coverage 76.33% 76.31% -0.02%
==========================================
Files 329 329
Lines 104190 104193 +3
==========================================
- Hits 79530 79512 -18
- Misses 24660 24681 +21
Continue to review full report at Codecov.
|
If you run ./configure --with-config=srpm, it will not trigger the user m4 scripts to populate the dracut and udev directories. This causes a build error on Fedora 28. Make the dracut and udev lines conditional to get around this. Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes: openzfs#7326
tonyhutter
force-pushed
the
fedora28-dracutdir
branch
from
46e94b0
to
3f3a758
Compare
|
@behlendorf I made the -n change in my latest push. It's building ok in my Fedora 28 VM. I did notice that buildbot was using fc29 kernel |
If you run ./configure --with-config=srpm, it will not trigger the user m4 scripts to populate the dracut and udev directories. This causes a build error on Fedora 28. Make the dracut and udev lines conditional to get around this. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#7326 Closes openzfs#7328
If you run ./configure --with-config=srpm, it will not trigger the user m4 scripts to populate the dracut and udev directories. This causes a build error on Fedora 28. Make the dracut and udev lines conditional to get around this. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#7326 Closes openzfs#7328
If you run ./configure --with-config=srpm, it will not trigger the user m4 scripts to populate the dracut and udev directories. This causes a build error on Fedora 28. Make the dracut and udev lines conditional to get around this. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes #7326 Closes #7328
Description
If you run ./configure --with-config=srpm, it will not trigger the user m4 scripts to populate the dracut and udev directories. This causes a build error on Fedora 28. Make the dracut and udev lines conditional to get around this.
Motivation and Context
Fix one part of Fedora 28 builds. Closes: #7326
How Has This Been Tested?
Tested on Fedora 28 rawhide VM.
Types of changes
Checklist:
Signed-off-by.