Fix reporting of L2ARC hits/misses in arc_summary3 #9669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arc_summary3 reports L2ARC hits and misses as Bytes, whereas they should be reported as events. arc_summary2 reports these correctly. Signed-off-by: George Amanakis <gamanakis@gmail.com>
|
@gamanakis At least we now know how much effort you put into testing the persistent L2ARC :) |
behlendorf
approved these changes
Dec 3, 2019
PrivatePuffin
approved these changes
Dec 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #9669 +/- ##
========================================
- Coverage 79% 79% -<1%
========================================
Files 418 418
Lines 123557 123557
========================================
- Hits 98027 97884 -143
- Misses 25530 25673 +143
Continue to review full report at Codecov.
|
ghost
approved these changes
Dec 4, 2019
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
arc_summary3 reports L2ARC hits and misses as Bytes, whereas they should be reported as events. arc_summary2 reports these correctly. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: George Amanakis <gamanakis@gmail.com> Closes openzfs#9669
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
arc_summary3 reports L2ARC hits and misses as Bytes, whereas they should be reported as events. arc_summary2 reports these correctly. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: George Amanakis <gamanakis@gmail.com> Closes openzfs#9669
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
arc_summary3 reports L2ARC hits and misses as Bytes, whereas they should be reported as events. arc_summary2 reports these correctly. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: George Amanakis <gamanakis@gmail.com> Closes #9669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
arc_summary3 reports L2ARC hits and misses as Bytes.
Description
L2ARC hits and misses should be reported as events.
arc_summary2 reports these correctly.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.