Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Snowball_jll #10

Merged
merged 1 commit into from Nov 23, 2020
Merged

Use Snowball_jll #10

merged 1 commit into from Nov 23, 2020

Conversation

jpsamaroo
Copy link
Contributor

This is intended to fix #9 , although we'll need Snowball_jll rebuilt with the latest BinaryBuilder to fix musl-specific issues (and I've tested locally that it works with a rebuilt Snowball_jll). However, that is not necessary for this PR.

@codecov-io
Copy link

codecov-io commented Nov 21, 2020

Codecov Report

Merging #10 (80c4531) into master (a5000e5) will increase coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   88.64%   89.93%   +1.28%     
==========================================
  Files          16       16              
  Lines        1066     1152      +86     
==========================================
+ Hits          945     1036      +91     
+ Misses        121      116       -5     
Impacted Files Coverage Δ
src/StringAnalysis.jl 100.00% <ø> (ø)
src/lda.jl 100.00% <0.00%> (ø)
src/hash.jl 100.00% <0.00%> (ø)
src/show.jl 100.00% <0.00%> (ø)
src/stats.jl 100.00% <0.00%> (ø)
src/document.jl 55.07% <0.00%> (ø)
src/ngramizer.jl 100.00% <0.00%> (ø)
src/rp.jl 90.97% <0.00%> (+0.06%) ⬆️
src/lsa.jl 91.09% <0.00%> (+0.18%) ⬆️
src/corpus.jl 87.62% <0.00%> (+0.27%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5000e5...80c4531. Read the comment docs.

@zgornel zgornel merged commit c2dd7a6 into zgornel:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringAnalysis doesn't support musl libc
3 participants