Fix crashing issue when total vertical padding is larger than the View's height #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I noticed that AndroidFastScroll can cause weird app crashing in a certain situation.
The crash log message
Here's the extracted message from the Logcat when my app crashed.
I can see an error occurred in the
RenderThread
thread and someone trying to create a negative height (-196 px
) View.Investigation result
When FastScroller attached view's height is smaller than its total vertical padding, the track view created in FastScroller will be requested to layout with inappropriate coordinates.
Proposed fix
Cramping the bottom position value with the top position value not to request negative height when layout the track view.